[core] fix(Overlay2): use mutable stack ref, fix document event listeners #6681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WIP fix useOverlayStackBuild artifact links for this commit: documentation | landing | table | demoThis is an automated comment from the deploy-preview CircleCI job. |
use mutable stackBuild artifact links for this commit: documentation | landing | table | demoThis is an automated comment from the deploy-preview CircleCI job. |
adidahiya
changed the title
adidahiya
commented
Jan 29, 2024
Comment on lines
+27
to
+28
| <OverlaysProvider> | ||
| <HotkeysProvider> |
There was a problem hiding this comment.
need to add docs about the ordering of these providers. will do that in a separate PR which adds <BlueprintProvider>
fix lint: break import cycleBuild artifact links for this commit: documentation | landing | table | demoThis is an automated comment from the deploy-preview CircleCI job. |
adidahiya
commented
Jan 30, 2024
| @@ -55,6 +55,9 @@ export interface OverlayInstance { | |||
| /** Document "focus" event handler which needs to be attached & detached appropriately. */ | |||
| handleDocumentFocus: (e: FocusEvent) => void; | |||
|
|
|||
| /** Document "mousedown" event handler which needs to be attached & detached appropriately. */ | |||
There was a problem hiding this comment.
now that there's an appropriate global context manager to handle this kind of logic, we should consider refactoring this behavior to have a single handler for the whole overlay stack instead of separate handlers for each overlay which need to be attached/detached. that would likely be safer and less prone to memory leaks.
This was referenced Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6679
Checklist
Changes proposed in this pull request:
Overlay2): improve overlay stack state management to fix document mousedown event handlerReviewers should focus on:
Fixes the linked bug
Screenshot