-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core] feat: CompoundTag #6686
[core] feat: CompoundTag #6686
Conversation
Add unit testsBuild artifact links for this commit: documentation | landing | table | demoThis is an automated comment from the deploy-preview CircleCI job. |
One more update: Per the darkmode updates, darkmode default tag colors should be the same as lightmode default tag, both backgrounds + text |
fix tag testsBuild artifact links for this commit: documentation | landing | table | demoThis is an automated comment from the deploy-preview CircleCI job. |
@jessperrin thanks for the color table, I will fix those. The hover and active colors are under-specified right now -- I am using the darker values (referenced in my PR comment above) for active states like this: |
fix colorsBuild artifact links for this commit: documentation | landing | table | demoThis is an automated comment from the deploy-preview CircleCI job. |
remove multiline prop from CompoundTagBuild artifact links for this commit: documentation | landing | table | demoThis is an automated comment from the deploy-preview CircleCI job. |
fix tests, make leftContent and children requiredBuild artifact links for this commit: documentation | landing | table | demoThis is an automated comment from the deploy-preview CircleCI job. |
Checklist
Changes proposed in this pull request:
New CompoundTag component
Reviewers should focus on:
Implementation matches Figma designs
Screenshot
Interactive demo