Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stabilize TooltipContext value #6690

Merged
merged 1 commit into from
Jan 31, 2024
Merged

Conversation

braeden
Copy link
Contributor

@braeden braeden commented Jan 31, 2024

Related to #5178 + #6652

Checklist

  • Includes tests
  • Update documentation

Changes proposed in this pull request:

Related to #6652. Stabilize the value to have renders avoid thrashing downstream consumers.

Reviewers should focus on:

Screenshot

Copy link
Contributor

@adidahiya adidahiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oof, these reducers are more trouble than they're worth for simple use cases. I think we'd be better off just using a simple state ref like I've done with OverlaysProvider... a refactor for a future PR

@adidahiya
Copy link
Contributor

Stabilize TooltipContext value

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

@adidahiya adidahiya merged commit 159e254 into develop Jan 31, 2024
12 checks passed
@adidahiya adidahiya deleted the braedens/stablize-tooltip-context branch January 31, 2024 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants