[icons] feat: "binary-number", "curly-braces" #6696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adidahiya
suggested changes
Feb 5, 2024
| { | ||
| "displayName": "Curly braces", | ||
| "iconName": "curly-braces", | ||
| "tags": "data, type, format，punctuation, grammar", |
There was a problem hiding this comment.
can you explain the connection with "data" for this icon?
What is this icon going to be used for?
does it belong in the "editor" group of icons?
There was a problem hiding this comment.
We want to use this icon for the "Struct" data type in Pipeline Builder.
adidahiya
changed the title
Co-authored-by: Adi Dahiya <adi.dahiya14@gmail.com>
Co-authored-by: Adi Dahiya <adi.dahiya14@gmail.com>
Co-authored-by: Adi Dahiya <adi.dahiya14@gmail.com>
adidahiya
reviewed
Feb 5, 2024
|
both sizes look good in docs preview
|
adidahiya
approved these changes
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewers should focus on:
Add "binary number" and "curly braces" icons.
Screenshot