[core] fix(EditableText): Update dimensions on placeholder change #6718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adidahiya
approved these changes
Feb 21, 2024
adidahiya
pushed a commit
that referenced
this pull request
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Changes proposed in this pull request:
Makes sure
EditableTextupdates its dimensions whenplaceholderis modified.This sandbox highlights the issue. Change the placeholder (via the top input) to something that doesn't match the input's current width, then focus either of the
EditableTexts below to see the difference.Reviewers should focus on:
If I missed something?
The current tests don't include any for the resizing, so I don't think it's in scope for such a small PR to add those.
Screenshot