-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core] feat: more dark theme color aliases #6724
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
[core] feat: more dark theme color aliasesBuild artifact links for this commit: documentation | landing | table | demoThis is an automated comment from the deploy-preview CircleCI job. |
Add generated changelog entriesBuild artifact links for this commit: documentation | landing | table | demoThis is an automated comment from the deploy-preview CircleCI job. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
||
&.#{$ns}-dark { | ||
background-color: $dark-content-background-color; | ||
background-color: $pt-dark-app-background-color; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actually, strike that last comment -- the change to docs-theme is fine. the color aliases being used were inconsistent before; we were using "app background color" for light theme but something else for dark theme, and this change unifies them to be symmetrical. so it's a welcome fix for the docs-theme package and it doesn't darken things so much that we need all the adjustments from #6711
Co-authored-by: svc-changelog <svc-changelog@palantir.com>
Ported relevant preflight changes from #6711 to help with a smoother migration to the newer dark theme colors
Checklist
Changes proposed in this pull request:
Reviewers should focus on:
No regressions / visual changes in docs styling
Screenshot