Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] feat: more dark theme color aliases #6724

Merged
merged 3 commits into from
Feb 23, 2024
Merged

Conversation

adidahiya
Copy link
Contributor

Ported relevant preflight changes from #6711 to help with a smoother migration to the newer dark theme colors

Checklist

  • Includes tests
  • Update documentation

Changes proposed in this pull request:

  • Add new dark theme color aliases
  • Use some of these aliases across core components and docs-theme package

Reviewers should focus on:

No regressions / visual changes in docs styling

Screenshot

@changelog-app

This comment was marked as resolved.

@adidahiya
Copy link
Contributor Author

[core] feat: more dark theme color aliases

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

@adidahiya
Copy link
Contributor Author

Add generated changelog entries

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

Copy link
Contributor Author

@adidahiya adidahiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docs app background is darker now, that is unintentional intentional for this PR:

After:

image

Before:

image


&.#{$ns}-dark {
background-color: $dark-content-background-color;
background-color: $pt-dark-app-background-color;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually, strike that last comment -- the change to docs-theme is fine. the color aliases being used were inconsistent before; we were using "app background color" for light theme but something else for dark theme, and this change unifies them to be symmetrical. so it's a welcome fix for the docs-theme package and it doesn't darken things so much that we need all the adjustments from #6711

@adidahiya adidahiya merged commit 39485bb into develop Feb 23, 2024
12 checks passed
@adidahiya adidahiya deleted the ad/dark-theme-variables branch February 23, 2024 21:17
adidahiya added a commit that referenced this pull request Feb 26, 2024
Co-authored-by: svc-changelog <svc-changelog@palantir.com>
@ggdouglas ggdouglas mentioned this pull request Nov 21, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants