Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hotkeys dialog having 2 scrollbars #6762

Merged
merged 1 commit into from
Apr 19, 2024

Conversation

okaynik
Copy link
Contributor

@okaynik okaynik commented Apr 10, 2024

Fixes #0000

Checklist

  • Includes tests
  • Update documentation

Changes proposed in this pull request:

Fix hotkey dialog having 2 scrollbars.

Reviewers should focus on:

Both hotkey-column and dialog-body-scroll-container have overflow: auto property. Add DialogBody to HotkeysDialogLegacy and remove overflow: scroll from hotkey-column.

Screenshot

Before After
image image

@changelog-app
Copy link

changelog-app bot commented Apr 10, 2024

Generate changelog in packages/core/changelog/@unreleased

What do the change types mean?
  • feature: A new feature of the service.
  • improvement: An incremental improvement in the functionality or operation of the service.
  • fix: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way.
  • break: Has the potential to break consumers of this service's API, inclusive of both Palantir services
    and external consumers of the service's API (e.g. customer-written software or integrations).
  • deprecation: Advertises the intention to remove service functionality without any change to the
    operation of the service itself.
  • manualTask: Requires the possibility of manual intervention (running a script, eyeballing configuration,
    performing database surgery, ...) at the time of upgrade for it to succeed.
  • migration: A fully automatic upgrade migration task with no engineer input required.

Note: only one type should be chosen.

How are new versions calculated?
  • ❗The break and manual task changelog types will result in a major release!
  • 🐛 The fix changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease.
  • ✨ All others will result in a minor version release.

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

Fix hotkeys dialog having 2 scrollbars

Check the box to generate changelog(s)

  • Generate changelog entry

@svc-palantir-github
Copy link

fix hotkeys dialog having 2 scrollbars

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

Copy link
Contributor

@michael-yx-wu michael-yx-wu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot quite repro the before state on the current version of the docs with the scrollbars displayed side-by-side, although I do see two scrollbars overlapped on top of each other briefly and can confirm that scrolling doesn't work well because of the two scrollbars.

Instead of disabling the scroll container on DialogBody, can you instead add a DialogBody to the legacy implementation. Replacing this line with the actual component:

<div className={Classes.DIALOG_BODY}>{this.renderHotkeys()}</div>

Then we could probably just remove these styles from the HOTKEY_COLUMN class

max-height: 80vh;
overflow-y: auto;

@okaynik okaynik force-pushed the nm/hotkey-dialog-double-scroll branch from c2c6487 to 387163d Compare April 11, 2024 19:17
@svc-palantir-github
Copy link

fix 2 scrollbars

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

Copy link
Contributor

@ericjeney ericjeney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I was able to confirm this by setting "Show scroll bars" to "Always" in macOS's System Settings.

@ericjeney ericjeney merged commit a19169c into develop Apr 19, 2024
12 of 14 checks passed
@ericjeney ericjeney deleted the nm/hotkey-dialog-double-scroll branch April 19, 2024 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants