Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] fix: toasters closing immediately on hover if timeout is set to 0 #6783

Merged
merged 1 commit into from
May 3, 2024
Merged

[core] fix: toasters closing immediately on hover if timeout is set to 0 #6783

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion packages/core/src/components/toast/toast2.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,12 +43,15 @@ export const Toast2 = React.forwardRef<HTMLDivElement, ToastProps>((props, ref)
const startTimeout = React.useCallback(() => setIsTimeoutStarted(true), []);
const clearTimeout = React.useCallback(() => setIsTimeoutStarted(false), []);

// Per docs: "Providing a value less than or equal to 0 will disable the timeout (this is discouraged)."
const isTimeoutEnabled = timeout != null && timeout > 0;

// timeout is triggered & cancelled by updating `isTimeoutStarted` state
useTimeout(
() => {
triggerDismiss(true);
},
isTimeoutStarted && timeout !== undefined ? timeout : null,
isTimeoutStarted && isTimeoutEnabled ? timeout : null,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fix looks simple. The hard part was making sure it was the right fix, which I ended up convincing myself is the case.

);

// start timeout on mount or change, cancel on unmount
Expand Down