Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] style: comment why start/clear timeout handlers are attached to mouse events #6784

Merged
merged 1 commit into from
May 3, 2024

Conversation

gluxon
Copy link
Contributor

@gluxon gluxon commented May 3, 2024

While looking at #6783, It took me a minute to realize why onMouseEnter/onMouseLeave events were being registered for toasters in the first place.

It took me a minute to realize why onMouseEnter/onMouseLeave events
were being registered for toasters in the first place.
@gluxon gluxon marked this pull request as ready for review May 3, 2024 03:48
@gluxon gluxon requested review from ericjeney and pgoldberg May 3, 2024 03:48
@svc-palantir-github
Copy link

Comment why start/clear timeout handlers are attached to mouse events

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

Copy link
Contributor

@pgoldberg pgoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! It also took me a second to understand why we were using mouse events here

@gluxon
Copy link
Contributor Author

gluxon commented May 3, 2024

Glad I wasn't the only one!

@gluxon gluxon merged commit e094518 into develop May 3, 2024
14 checks passed
@gluxon gluxon deleted the bcheng/toast2-comment branch May 3, 2024 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants