Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] fix: do not colour FormGroup sub label based on intent #6811

Merged
merged 3 commits into from
May 20, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/core/changelog/@unreleased/pr-6811.v2.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
type: improvement
improvement:
description: Do not colour FormGroup sub label based on intent
links:
- https://github.com/palantir/blueprint/pull/6811
2 changes: 0 additions & 2 deletions packages/core/src/components/forms/_form-group.scss
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,6 @@ Styleguide form-group
/* stylelint-disable-next-line order/declaration-block-order */
@each $intent, $color in $pt-intent-text-colors {
&.#{$ns}-intent-#{$intent} {
.#{$ns}-form-group-sub-label,
.#{$ns}-form-helper-text {
color: $color;
}
Expand Down Expand Up @@ -102,7 +101,6 @@ Styleguide form-group
.#{$ns}-dark & {
@each $intent, $color in $pt-dark-intent-text-colors {
&.#{$ns}-intent-#{$intent} {
.#{$ns}-form-group-sub-label,
.#{$ns}-form-helper-text {
color: $color;
}
Expand Down
3 changes: 1 addition & 2 deletions packages/core/src/components/forms/formGroup.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -76,8 +76,7 @@ export interface FormGroupProps extends IntentProps, Props {

/**
* Optional text for `label`. The given content will be wrapped in
* `Classes.FORM_GROUP_SUB_LABEL` and displayed beneath `label`. The text color
* is determined by the `intent`.
* `Classes.FORM_GROUP_SUB_LABEL` and displayed beneath `label`.
*/
subLabel?: React.ReactNode;
}
Expand Down