fix: prevent PanelStack2 from opening in the wrong direction #6847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your interest in palantir/blueprint, @stropitek! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request. |
evansjohnson
previously approved these changes
Jun 22, 2024
policy-bot
bot
dismissed
evansjohnson’s stale review
Invalidated by push of 0b4d5cb
stropitek
force-pushed
the
dk/panstack2-open-close-animation
branch
from
0b4d5cb
to
cbf3061
Compare
|
Thank you for the review @evansjohnson! I updated the PR based on it. |
evansjohnson
approved these changes
Jun 25, 2024
| } | ||
| stackLength.current = stack.length; | ||
| }, [stack]); | ||
| const prevStackLength = usePrevious(stack.length) ?? stack.length; |
There was a problem hiding this comment.
leaving comment for posterity - technically stack.length is not the previous stack length, but it lets us not worry about handling the undefined case, and there is no animation on the initial render anyways
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6723
As additional context that was not described in the original issue, I realized that the problem only exists when using react 18, not with react 16.
I did an example of the issue in an application running with react 18 in stackblitz, one without the fix, the other with the fix. By testing the example as described in #6723, you can verify the fix.
Before the fix: https://stackblitz.com/edit/vitejs-vite-4d5jhz
After the fix: https://stackblitz.com/edit/vitejs-vite-txizds
Checklist
Changes proposed in this pull request:
The changes removes one of the state that can be derived from other values directly, preventing unnecessary re-renders.
Reviewers should focus on:
Making sure the change does not break any existing behaviour.