Fix end time selection before selecting date #6858

evansjohnson · 2024-06-24T13:01:21Z

Fixes #6863

Fixes #6856

Previously, users could end up with a reversed selection range if modifying the time input of the end date before selecting a date. Today's date was used as the default in these cases, leaving the user with a reversed range if the start date was later than today's date.

Checklist

Includes tests
[-] Update documentation

Changes proposed in this pull request:

Fix behavior of default date such that selected range cannot end up reversed.
When allowSingleDayRange is not true, ensure the default date is 1 day off from the already selected date (otherwise keep today's date as default if no dates are selected).

Reviewers should focus on:

There's a slight behavior break in that users could previously select a single day range by modifying the time with today's date selected as the start date. This seems like a bug that's okay to fix but would like a second opinion on this.
Any better solutions than to add/subtract a day from the default when allowSingleDayRange is not true?
Would you prefer to see the allowSingleDayRange change split out?

changelog-app · 2024-06-24T13:01:26Z

Generate changelog in `packages/datetime2/changelog/@unreleased`

What do the change types mean?

feature: A new feature of the service.
improvement: An incremental improvement in the functionality or operation of the service.
fix: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way.
break: Has the potential to break consumers of this service's API, inclusive of both Palantir services
and external consumers of the service's API (e.g. customer-written software or integrations).
deprecation: Advertises the intention to remove service functionality without any change to the
operation of the service itself.
manualTask: Requires the possibility of manual intervention (running a script, eyeballing configuration,
performing database surgery, ...) at the time of upgrade for it to succeed.
migration: A fully automatic upgrade migration task with no engineer input required.

Note: only one type should be chosen.

How are new versions calculated?

❗The break and manual task changelog types will result in a major release!
🐛 The fix changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease.
✨ All others will result in a minor version release.

Type

Description

Fix DateRangePicker end time selection before selecting end date

Check the box to generate changelog(s)

Generate changelog entry

svc-palantir-github · 2024-06-24T13:09:43Z

Fix end time selection before selecting date

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

svc-palantir-github · 2024-06-24T13:48:43Z

lint

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

svc-palantir-github · 2024-06-24T15:38:47Z

prettier and test fix

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

svc-palantir-github · 2024-06-25T16:08:22Z

fix test

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

gluxon

Thank you!

gluxon · 2024-06-28T17:53:36Z

packages/datetime2/src/components/date-range-picker3/dateRangePicker3.tsx

        this.props.onChange?.(newDateRange);
        this.setState({ value: newDateRange, time: newTimeRange });
    };

+    private getDefaultDate = (dateIndex: number) => {
+        const { value } = this.state;


nitpick: I'm not too worried about this since this is already happening in the existing code, but I wonder if we need to grab existing state in the setState callback rather than reading directly off of this.state.

Otherwise we could end up with weird bugs if this.state is referring to stale values.

In general, any time "next state" is computed from some kind of prior state, I usually read the prior state in a setState callback.

oof yea, I remember dealing with stuff like this back when seeing class components more often

in this case I'm thinking let's leave as is since as you call out we access this.state just before calling this helper method

Agree! Let's leave as-is. I almost didn't make this comment because it was an existing issue.

gluxon · 2024-06-28T18:11:49Z

packages/datetime2/src/components/date-range-picker3/dateRangePicker3.tsx

        this.props.onChange?.(newDateRange);
        this.setState({ value: newDateRange, time: newTimeRange });
    };

+    private getDefaultDate = (dateIndex: number) => {


Just as a suggestion, I think we can add an inline source code comment to explain why we need to be careful about selecting the next default date.

Maybe something around:

When someone sets the time value before choosing a date, we need to "infer" or pick a date for them to initialize.

The next default date for the 0 or 1 index depends on the value of the other index since there's an invariant that the left/0 date is always less than the right/1 date.

packages/datetime2/src/components/date-range-picker3/dateRangePicker3.tsx

…Picker3.tsx

Invalidated by push of 538464f

packages/datetime2/src/components/date-range-picker3/dateRangePicker3.tsx

…Picker3.tsx

svc-palantir-github · 2024-06-28T19:03:47Z

Update packages/datetime2/src/components/date-range-picker3/dateRangePicker3.tsx

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

gluxon

Sweet! Thanks for the comment on getDefaultDate.

Invalidated by push of 6e133a2

svc-palantir-github · 2024-07-01T19:04:57Z

Add generated changelog entries

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

Fix end time selection before selecting date

d8d9fc6

evansjohnson added 2 commits June 24, 2024 09:27

add tests

1ce57b1

lint

021d4a2

prettier and test fix

5e01be0

ericjeney assigned invliD Jun 24, 2024

fix test

603e0cd

evansjohnson requested a review from invliD June 26, 2024 20:38

gluxon self-assigned this Jun 28, 2024

gluxon previously approved these changes Jun 28, 2024

View reviewed changes

evansjohnson commented Jun 28, 2024

View reviewed changes

packages/datetime2/src/components/date-range-picker3/dateRangePicker3.tsx Show resolved Hide resolved

Update packages/datetime2/src/components/date-range-picker3/dateRange…

538464f

…Picker3.tsx

evansjohnson commented Jun 28, 2024

View reviewed changes

packages/datetime2/src/components/date-range-picker3/dateRangePicker3.tsx Outdated Show resolved Hide resolved

Update packages/datetime2/src/components/date-range-picker3/dateRange…

49f8344

…Picker3.tsx

gluxon previously approved these changes Jul 1, 2024

View reviewed changes

Add generated changelog entries

6e133a2

gluxon approved these changes Jul 1, 2024

View reviewed changes

evansjohnson merged commit f2e9d6e into develop Jul 2, 2024
13 checks passed

evansjohnson deleted the evanj/daterange-end-time-fix branch July 2, 2024 18:18

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix end time selection before selecting date #6858

Fix end time selection before selecting date #6858

evansjohnson commented Jun 24, 2024 •

edited

Loading

changelog-app bot commented Jun 24, 2024 •

edited by evansjohnson

Loading

svc-palantir-github commented Jun 24, 2024

svc-palantir-github commented Jun 24, 2024

svc-palantir-github commented Jun 24, 2024

svc-palantir-github commented Jun 25, 2024

gluxon left a comment

gluxon Jun 28, 2024

evansjohnson Jun 28, 2024

gluxon Jul 1, 2024

gluxon Jun 28, 2024

svc-palantir-github commented Jun 28, 2024

gluxon left a comment

svc-palantir-github commented Jul 1, 2024

Fix end time selection before selecting date #6858

Fix end time selection before selecting date #6858

Conversation

evansjohnson commented Jun 24, 2024 • edited Loading

Fixes #6863

Fixes #6856

Checklist

Changes proposed in this pull request:

Reviewers should focus on:

changelog-app bot commented Jun 24, 2024 • edited by evansjohnson Loading

Generate changelog in packages/datetime2/changelog/@unreleased

svc-palantir-github commented Jun 24, 2024

Fix end time selection before selecting date

svc-palantir-github commented Jun 24, 2024

lint

svc-palantir-github commented Jun 24, 2024

prettier and test fix

svc-palantir-github commented Jun 25, 2024

fix test

gluxon left a comment

Choose a reason for hiding this comment

gluxon Jun 28, 2024

Choose a reason for hiding this comment

evansjohnson Jun 28, 2024

Choose a reason for hiding this comment

gluxon Jul 1, 2024

Choose a reason for hiding this comment

gluxon Jun 28, 2024

Choose a reason for hiding this comment

svc-palantir-github commented Jun 28, 2024

Update packages/datetime2/src/components/date-range-picker3/dateRangePicker3.tsx

gluxon left a comment

Choose a reason for hiding this comment

svc-palantir-github commented Jul 1, 2024

Add generated changelog entries

evansjohnson commented Jun 24, 2024 •

edited

Loading

changelog-app bot commented Jun 24, 2024 •

edited by evansjohnson

Loading

Generate changelog in `packages/datetime2/changelog/@unreleased`