test: improve tabs tests #6898
test: improve tabs tests #6898
Conversation
Generate changelog in
|
| const TAB = "[role='tab']"; | ||
| const TAB_LIST = "[role='tablist']"; | ||
| const TAB_PANEL = "[role='tabpanel']"; | ||
| const TAB_SELECTOR = `.${Classes.TAB}`; |
There was a problem hiding this comment.
No other test grabs by role-- use Classes like the rest.
There was a problem hiding this comment.
I've always heard it's best to select elements in tests as close as possible as to how your users would. Ideally by actual text content, followed by accessibility roles/element types (ex user searches for and clicks a <button>), and as a last resort something like targeting by an id or special test-id attribute.
So I don't think we should change these tests just because other tests are selecting by class name.
| const NUM_TABS = 3; | ||
| assert.lengthOf(wrapper.find(TAB_SELECTOR), NUM_TABS); | ||
| assert.lengthOf(wrapper.find(TAB_PANEL_SELECTOR), NUM_TABS); | ||
| assert.lengthOf(wrapper.find(`.${tabClassName}`).hostNodes(), NUM_TABS * 2); |
There was a problem hiding this comment.
Should not have length 9, should have length 6. Need to use hostNodes to remove the React nodes.
| const TAB = "[role='tab']"; | ||
| const TAB_LIST = "[role='tablist']"; | ||
| const TAB_PANEL = "[role='tabpanel']"; | ||
| const TAB_SELECTOR = `.${Classes.TAB}`; |
There was a problem hiding this comment.
I've always heard it's best to select elements in tests as close as possible as to how your users would. Ideally by actual text content, followed by accessibility roles/element types (ex user searches for and clicks a <button>), and as a last resort something like targeting by an id or special test-id attribute.
So I don't think we should change these tests just because other tests are selecting by class name.
| @@ -0,0 +1,5 @@ | |||
| type: improvement | |||
| fix: | |||
| description: '[core] a11y(Tooltip): wrap contents in "tooltip" aria role' | |||
There was a problem hiding this comment.
lemme know if you think the
hostNodeschange is important###
This PR is a precursor to #6896 , where this change is more beneficial
…vt/blueprint into bvandercar/test/tabs
Fixes #0000
Checklist