[Icons] Update CSSStyle and add TableSync #6913
Conversation
FormatBuild artifact links for this commit: documentation | landing | table | demoThis is an automated comment from the deploy-preview CircleCI job. |
resources/icons/20px/data-sync.svg
Outdated
There was a problem hiding this comment.
I think this should probably be added as a new icon
right now the data-sync icon lines up with the database and data-connection icons and this would break that:
perhaps this could be something like table-sync or datasource-sync
There was a problem hiding this comment.
Added table-sync as it's own icon
zaini
changed the title
Add table sync iconBuild artifact links for this commit: documentation | landing | table | demoThis is an automated comment from the deploy-preview CircleCI job. |
There was a problem hiding this comment.
a bit of a nit but could we either call this data-table-sync or use the same underlying table icon with only one small column and a wider space to the right?
I'm thinking we may end up with a full set of data-table icons and it would be nice to either give them a unique prefix, or just stick with the underlying table icon
There was a problem hiding this comment.
decided against this - "Data table" is a bit redundant and there's no need to have a separate set of "data table" icons from "table" just because of the # of columns. # of columns can be dictated by what works best for the particular icon (ex see "Table: disconnect")
revertBuild artifact links for this commit: documentation | landing | table | demoThis is an automated comment from the deploy-preview CircleCI job. |
Fixes #0000
Checklist
Changes proposed in this pull request:
Update CSSStyle and add TableSync
Reviewers should focus on:
New icon designs.
Screenshot
Reach out to xinyifu on Slack for design nits.