Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Icons] Add database-search icon #6921

Merged
merged 6 commits into from
Jul 24, 2024
Merged

Conversation

zaini
Copy link
Contributor

@zaini zaini commented Jul 23, 2024

Fixes #0000

Checklist

  • Includes tests
  • Update documentation

Changes proposed in this pull request:

Add database-search icon

Reviewers should focus on:

Icon design

Screenshot

image

@changelog-app
Copy link

changelog-app bot commented Jul 23, 2024

Generate changelog in packages/icons/changelog/@unreleased

What do the change types mean?
  • feature: A new feature of the service.
  • improvement: An incremental improvement in the functionality or operation of the service.
  • fix: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way.
  • break: Has the potential to break consumers of this service's API, inclusive of both Palantir services
    and external consumers of the service's API (e.g. customer-written software or integrations).
  • deprecation: Advertises the intention to remove service functionality without any change to the
    operation of the service itself.
  • manualTask: Requires the possibility of manual intervention (running a script, eyeballing configuration,
    performing database surgery, ...) at the time of upgrade for it to succeed.
  • migration: A fully automatic upgrade migration task with no engineer input required.

Note: only one type should be chosen.

How are new versions calculated?
  • ❗The break and manual task changelog types will result in a major release!
  • 🐛 The fix changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease.
  • ✨ All others will result in a minor version release.

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

[Icons] Add database-search icon

Check the box to generate changelog(s)

  • Generate changelog entry

@svc-palantir-github
Copy link

Add generated changelog entries

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

Copy link
Contributor

@evansjohnson evansjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could we move all of the database icons into the Data group and also add tags so that they all show up if searching database?

(screenshot not from PR preview so database-search not shown)
Screenshot 2024-07-24 at 9 44 09 AM

},
{
"displayName": "Database search",
"iconName": "database-search",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noting this differs from existing database icons that have some decoration
Screenshot 2024-07-24 at 9 41 29 AM
Screenshot 2024-07-24 at 9 41 24 AM

but the clean database icon is named "database" so no clear preference here. my vote is to align this with the base icon and considers the others slightly off-named

@zaini zaini requested a review from evansjohnson July 24, 2024 15:21
evansjohnson
evansjohnson previously approved these changes Jul 24, 2024
@policy-bot policy-bot bot dismissed evansjohnson’s stale review July 24, 2024 15:27

Invalidated by push of 439cf86

evansjohnson
evansjohnson previously approved these changes Jul 24, 2024
Copy link
Contributor

@evansjohnson evansjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-approving!

@policy-bot policy-bot bot dismissed evansjohnson’s stale review July 24, 2024 15:28

Invalidated by push of de7c86e

Copy link
Contributor

@evansjohnson evansjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@zaini zaini merged commit 90dfbaa into develop Jul 24, 2024
6 of 7 checks passed
@zaini zaini deleted the zaini/add-database-search-icon branch July 24, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants