-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add minimal prop to Callout which hides the background fill color #6952
Conversation
Generate changelog in
|
Add generated changelog entriesBuild artifact links for this commit: documentation | landing | table | demoThis is an automated comment from the deploy-preview CircleCI job. |
&.#{$ns}-minimal.#{$ns}-intent-danger { | ||
background-color: transparent; | ||
} | ||
|
||
.#{$ns}-dark & { | ||
background-color: rgba($gray3, 0.2); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
&.#{$ns}-minimal.#{$ns}-intent-warning, | ||
&.#{$ns}-minimal.#{$ns}-intent-danger { | ||
background-color: transparent; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of explicitly overwriting styles, could we instead use a negation pseudo-class to prevent the background color from being applied in the first case if the callout is minimal? e.g.
.#{$ns}-callout {
&:not(.#{$ns}-minimal) {
background-color: rgba($gray3, 0.15);
}
.#{$ns}-dark & {
&:not(.#{$ns}-minimal) {
background-color: rgba($gray3, 0.2);
}
}
@each $intent, $color in $pt-intent-colors {
&.#{$ns}-intent-#{$intent} {
&:not(.#{$ns}-minimal) {
background-color: rgba($color, 0.1);
}
.#{$ns}-dark & {
&:not(.#{$ns}-minimal) {
background-color: rgba($color, 0.2);
}
}
}
}
}
Address commentsBuild artifact links for this commit: documentation | landing | table | demoThis is an automated comment from the deploy-preview CircleCI job. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
Invalidated by push of 79ce206
lintBuild artifact links for this commit: documentation | landing | table | demoThis is an automated comment from the deploy-preview CircleCI job. |
Checklist
Changes proposed in this pull request:
New minimal prop on the Callout component that hides the background fill color
Reviewers should focus on: