Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: new icon - Globe: network add #7008

Merged
merged 7 commits into from
Oct 8, 2024
Merged

Conversation

williamshammond
Copy link
Contributor

@williamshammond williamshammond commented Oct 3, 2024

Fixes N/A, adds new icon

Checklist

  • Includes tests (N/A)
  • Update documentation (N/A)

Changes proposed in this pull request:

  • Adds new icon "Globe: network add" similar to "Globe: network" but with an addition symbol in the top right in the style of many other blueprint components
  • Titled "Globe: network add" which is tricky due to the double modifier but follows the style of "Folder: shared open" "Sort: numerical descending" and other icons with two modifier words

Reviewers should focus on:

  • The title and if the convention makes sense

Screenshot

Screenshot 2024-10-03 at 3 12 17 PM

@changelog-app
Copy link

changelog-app bot commented Oct 3, 2024

Generate changelog in packages/icons/changelog/@unreleased

What do the change types mean?
  • feature: A new feature of the service.
  • improvement: An incremental improvement in the functionality or operation of the service.
  • fix: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way.
  • break: Has the potential to break consumers of this service's API, inclusive of both Palantir services
    and external consumers of the service's API (e.g. customer-written software or integrations).
  • deprecation: Advertises the intention to remove service functionality without any change to the
    operation of the service itself.
  • manualTask: Requires the possibility of manual intervention (running a script, eyeballing configuration,
    performing database surgery, ...) at the time of upgrade for it to succeed.
  • migration: A fully automatic upgrade migration task with no engineer input required.

Note: only one type should be chosen.

How are new versions calculated?
  • ❗The break and manual task changelog types will result in a major release!
  • 🐛 The fix changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease.
  • ✨ All others will result in a minor version release.

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

feat: new icon - Globe: network add

Check the box to generate changelog(s)

  • Generate changelog entry

@svc-palantir-github
Copy link

Add generated changelog entries

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

@williamshammond williamshammond force-pushed the wh/add-add-globe-network-icon branch from 154816f to f62acab Compare October 7, 2024 19:57
@svc-palantir-github
Copy link

Fix newline

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

@svc-palantir-github
Copy link

Eliminate fill-rule attribute by switching path to comply with nonzero

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

@ggdouglas ggdouglas merged commit 0cb9e27 into develop Oct 8, 2024
11 of 14 checks passed
@ggdouglas ggdouglas deleted the wh/add-add-globe-network-icon branch October 8, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants