Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not toggle edit mode with escape key during IME composition #7024

Merged
merged 5 commits into from
Oct 30, 2024

Conversation

natsuozawa
Copy link
Member

@natsuozawa natsuozawa commented Oct 24, 2024

Following up on #7021

Checklist

  • Includes tests
  • Update documentation

Changes proposed in this pull request:

Do not toggle edit mode with escape key during IME composition

Reviewers should focus on:

Screenshot

@changelog-app
Copy link

changelog-app bot commented Oct 24, 2024

Generate changelog in packages/core/changelog/@unreleased

What do the change types mean?
  • feature: A new feature of the service.
  • improvement: An incremental improvement in the functionality or operation of the service.
  • fix: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way.
  • break: Has the potential to break consumers of this service's API, inclusive of both Palantir services
    and external consumers of the service's API (e.g. customer-written software or integrations).
  • deprecation: Advertises the intention to remove service functionality without any change to the
    operation of the service itself.
  • manualTask: Requires the possibility of manual intervention (running a script, eyeballing configuration,
    performing database surgery, ...) at the time of upgrade for it to succeed.
  • migration: A fully automatic upgrade migration task with no engineer input required.

Note: only one type should be chosen.

How are new versions calculated?
  • ❗The break and manual task changelog types will result in a major release!
  • 🐛 The fix changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease.
  • ✨ All others will result in a minor version release.

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

Do not toggle edit mode with escape key during IME composition

Check the box to generate changelog(s)

  • Generate changelog entry

@natsuozawa natsuozawa changed the title WIP Do not toggle edit mode with escape key during IME composition Oct 24, 2024
@natsuozawa natsuozawa self-assigned this Oct 24, 2024
@svc-palantir-github
Copy link

Merge branch 'develop' into nozawa/more-iscomposing-checks

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

@svc-palantir-github
Copy link

Move isComposing check

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

@ggdouglas ggdouglas merged commit bee98b2 into develop Oct 30, 2024
11 of 13 checks passed
@ggdouglas ggdouglas deleted the nozawa/more-iscomposing-checks branch October 30, 2024 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants