Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Changes proposed in this pull request:
This PR fixes a bug in the query list component (as used in Select) where IME enter and arrow key keyboard events are not ignored, as they should be, causing IME confirmation to result in selecting a value and other sadness.
Reviewers should focus on:
It's a little weird that we already had the
isEnterKeyPressed
logic mostly in place to catch IME events, but didn't have the actual "is composing" check needed to make it actually do what it was supposed to do. Maybe just an oversight?Before
ime-bug-before-fix.mov
After
ime-bug-after-fix.mov