Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix IME bug in QueryList #7028

Merged
merged 2 commits into from
Nov 5, 2024
Merged

Conversation

AaronJRubin
Copy link
Contributor

@AaronJRubin AaronJRubin commented Oct 26, 2024

Checklist

  • Includes tests
  • Update documentation

Changes proposed in this pull request:

This PR fixes a bug in the query list component (as used in Select) where IME enter and arrow key keyboard events are not ignored, as they should be, causing IME confirmation to result in selecting a value and other sadness.

Reviewers should focus on:

It's a little weird that we already had the isEnterKeyPressed logic mostly in place to catch IME events, but didn't have the actual "is composing" check needed to make it actually do what it was supposed to do. Maybe just an oversight?

Before

ime-bug-before-fix.mov

After

ime-bug-after-fix.mov

@changelog-app
Copy link

changelog-app bot commented Oct 26, 2024

Generate changelog in packages/select/changelog/@unreleased

What do the change types mean?
  • feature: A new feature of the service.
  • improvement: An incremental improvement in the functionality or operation of the service.
  • fix: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way.
  • break: Has the potential to break consumers of this service's API, inclusive of both Palantir services
    and external consumers of the service's API (e.g. customer-written software or integrations).
  • deprecation: Advertises the intention to remove service functionality without any change to the
    operation of the service itself.
  • manualTask: Requires the possibility of manual intervention (running a script, eyeballing configuration,
    performing database surgery, ...) at the time of upgrade for it to succeed.
  • migration: A fully automatic upgrade migration task with no engineer input required.

Note: only one type should be chosen.

How are new versions calculated?
  • ❗The break and manual task changelog types will result in a major release!
  • 🐛 The fix changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease.
  • ✨ All others will result in a minor version release.

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

Fix IME bug in QueryList

Check the box to generate changelog(s)

  • Generate changelog entry

@AaronJRubin AaronJRubin marked this pull request as ready for review October 26, 2024 11:34
Copy link
Member

@invliD invliD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there's still a separate bug here where pressing Escape while composing closes the Select dropdown, though I think that needs to be fixed in the Overlay component.

@ggdouglas ggdouglas merged commit e40e976 into palantir:develop Nov 5, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants