Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix focus hang on MultiSelect/Suggest inputs in Firefox #7068

Merged
merged 2 commits into from
Nov 14, 2024

Conversation

ggdouglas
Copy link
Contributor

@ggdouglas ggdouglas commented Nov 14, 2024

Fixes #7055

Checklist

  • Includes tests
  • Update documentation

Changes proposed in this pull request:

Fixes an issue where MultiSelect/Suggest component input fields would inadvertently capture tab focus in Firefox, preventing focus from moving to the rest of the document.

Reviewers should focus on:

Ensure that tab focus works as expected on MultiSelect/Suggest components in both Chrome and Firefox.

Screenshot

Before After
before after

@changelog-app
Copy link

changelog-app bot commented Nov 14, 2024

Generate changelog in packages/select/changelog/@unreleased

What do the change types mean?
  • feature: A new feature of the service.
  • improvement: An incremental improvement in the functionality or operation of the service.
  • fix: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way.
  • break: Has the potential to break consumers of this service's API, inclusive of both Palantir services
    and external consumers of the service's API (e.g. customer-written software or integrations).
  • deprecation: Advertises the intention to remove service functionality without any change to the
    operation of the service itself.
  • manualTask: Requires the possibility of manual intervention (running a script, eyeballing configuration,
    performing database surgery, ...) at the time of upgrade for it to succeed.
  • migration: A fully automatic upgrade migration task with no engineer input required.

Note: only one type should be chosen.

How are new versions calculated?
  • ❗The break and manual task changelog types will result in a major release!
  • 🐛 The fix changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease.
  • ✨ All others will result in a minor version release.

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

Fix focus hang on MultiSelect/Suggest inputs in Firefox

Check the box to generate changelog(s)

  • Generate changelog entry

@svc-palantir-github
Copy link

Enable tab focus to move past suggest input in Firefox

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

@ggdouglas ggdouglas merged commit e1c8382 into develop Nov 14, 2024
12 of 14 checks passed
@ggdouglas ggdouglas deleted the gd/moz-select-input-focus-hang branch November 14, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Firefox accessibility problem with MultiSelect: focus hang
3 participants