add deprecation warning to Tabs constructor #767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adidahiya
approved these changes
Mar 3, 2017
| declare var process: { env: any }; | ||
|
|
||
| /** Returns whether `process.env.NODE_ENV` exists and equals `env`. */ | ||
| export function isNodeEnv(env: string) { |
There was a problem hiding this comment.
consider limiting this string type to just "development" | "production" | "test"
There was a problem hiding this comment.
seems overkill. also you don't get autocomplete so there's little advantage.
There was a problem hiding this comment.
no, I think it's actually quite meaningful -- why would you compare to other values?
vscode actually does give me autocomplete :P
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
Utils.isNodeEnvhelper function checks value ofprocess.env.NODE_ENV.