[Tabs] .pt-large .pt-tab uses simple nesting #862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
no .pt-tab-list involved! so in `Tabs2` you can put the class on the top element.
giladgray
changed the title
cmslewis
approved these changes
Mar 18, 2017
giladgray
commented
Mar 20, 2017
| @@ -261,6 +255,12 @@ $tab-indicator-width: 3px !default; | |||
| &:focus { | |||
| -moz-outline-radius: 0; | |||
| } | |||
|
|
|||
| &.pt-large, | |||
There was a problem hiding this comment.
remove this line, no need to enable this behavior yet
unnecessary at this stage
llorca
approved these changes
Mar 20, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #799
Changes proposed in this pull request:
.pt-largemodifier can be applied to any ancestor of.pt-tab, not just the.pt-tab-list:.pt-large .pt-tab<Tabs className={Classes.LARGE}>will give you nice large tabsReviewers should focus on:
tabListClassNameprop. is that preferable? might that be desirable anyway, even with this change?