Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce the default conjure connect timeout to 5 seconds (from 10) #2777

Merged
merged 2 commits into from
Jan 17, 2024

Conversation

carterkozak
Copy link
Contributor

Before this PR

10 second default connect timeout.

After this PR

==COMMIT_MSG==
Reduce the default conjure connect timeout to 5 seconds (from 10)
==COMMIT_MSG==

Possible downsides?

Oh goodness yes! If clients are interacting with tremendously latent servers which are expected to take longer than 5 seconds to connect, attempts to connect may fail. However, our metrics make it clear that is not something to expect, and happens rarely+intermittently enough that failing early + retrying will provide a better user experience. In the off-chance that longer times are expected, clients may be configured with larger connect-timeout values. Ultimately it would be ideal if we reduced connect timeout values below 1 seconds.

@changelog-app
Copy link

changelog-app bot commented Jan 12, 2024

Generate changelog in changelog/@unreleased

What do the change types mean?
  • feature: A new feature of the service.
  • improvement: An incremental improvement in the functionality or operation of the service.
  • fix: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way.
  • break: Has the potential to break consumers of this service's API, inclusive of both Palantir services
    and external consumers of the service's API (e.g. customer-written software or integrations).
  • deprecation: Advertises the intention to remove service functionality without any change to the
    operation of the service itself.
  • manualTask: Requires the possibility of manual intervention (running a script, eyeballing configuration,
    performing database surgery, ...) at the time of upgrade for it to succeed.
  • migration: A fully automatic upgrade migration task with no engineer input required.

Note: only one type should be chosen.

How are new versions calculated?
  • ❗The break and manual task changelog types will result in a major release!
  • 🐛 The fix changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease.
  • ✨ All others will result in a minor version release.

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

Reduce the default conjure connect timeout to 5 seconds (from 10)

Check the box to generate changelog(s)

  • Generate changelog entry

@bulldozer-bot bulldozer-bot bot merged commit 1a92543 into develop Jan 17, 2024
5 checks passed
@bulldozer-bot bulldozer-bot bot deleted the ckozak/connect_timeout branch January 17, 2024 22:10
@svc-autorelease
Copy link
Collaborator

Released 8.4.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants