Handle application/octet-stream in verification-client #276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
December 3, 2019 15:06
Generate changelog in
|
|
Tested against palantir/conjure-java-runtime and the binary client tests pass with this change |
added 3 commits
December 3, 2019 17:35
ferozco
reviewed
Dec 3, 2019
| @@ -158,7 +161,7 @@ impl VerificationClientResource { | |||
| let content_type = response | |||
There was a problem hiding this comment.
a content type should always be set, we should fail here if its not. It should also make the rest of the code cleaner
There was a problem hiding this comment.
not that much but can unwrap the optional as well
There was a problem hiding this comment.
we do not send content-type in 204 responses
|
👍 |
|
Released 0.18.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
We would try to deserialize application/octet-stream as json
After this PR
==COMMIT_MSG==
Don't try to deserialize applicaiton/octet-stream and handle it as a binary stream
==COMMIT_MSG==
Possible downsides?
N/A - this was missing functionality