Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate correct confirm endpoint #326

Merged
merged 4 commits into from
Mar 27, 2020
Merged

Conversation

ferozco
Copy link
Contributor

@ferozco ferozco commented Mar 27, 2020

Before this PR

The conjure bindings for the confirm endpoint of AutoDeserializeService inadvertently had a duplicate confirm/ path prefix

After this PR

==COMMIT_MSG==
Conjure bindings for AutoDeserializeServicecorrectly correctly reflect the the verifier's implementation
==COMMIT_MSG==

Possible downsides?

@changelog-app
Copy link

changelog-app bot commented Mar 27, 2020

Generate changelog in changelog/@unreleased

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

Conjure bindings for AutoDeserializeServicecorrectly correctly reflect the the verifier's implementation

Check the box to generate changelog(s)

  • Generate changelog entry

@policy-bot policy-bot bot requested a review from CRogers March 27, 2020 17:35
@ferozco ferozco requested review from iamdanfox and carterkozak and removed request for CRogers March 27, 2020 17:35
@ferozco
Copy link
Contributor Author

ferozco commented Mar 27, 2020

CircleCI is in a degraded state: https://status.circleci.com/

@bulldozer-bot bulldozer-bot bot merged commit e494501 into develop Mar 27, 2020
@bulldozer-bot bulldozer-bot bot deleted the fo/fix-conjure-api branch March 27, 2020 21:45
@svc-autorelease
Copy link
Collaborator

Released 0.18.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants