[compiler] feat: upgrade to Marked v9.0 #247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build preview link for commit "[compiler] feat: upgrade to Marked v9.0": documentation This is an automated comment from the deploy-preview CircleCI job. |
2 tasks
|
Build preview link for commit "update snapshot": documentation This is an automated comment from the deploy-preview CircleCI job. |
|
Build preview link for commit "Add changelog": documentation This is an automated comment from the deploy-preview CircleCI job. |
pgoldberg
approved these changes
Oct 27, 2023
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MarkedOptionsshould be mostly backwards compatible.@types/markedis no longer required now that the types are shipped with the package.This upgrade is intended to fix some rendering issues found here: palantir/blueprint#6476 (review)looks like it works fine without the upgrade. I tried this upgrade by usingyarn linkin the Blueprint repo, which means that the type breaks caused by the major bump should be minimal / negligible (I didn't have to fix any types).