Add error callbacks that emit metrics #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are non-default because they require a metrics registry, but the default handlers are now implemented by passing a nil registry to the metric version. Note that this contains an API break in the AsyncErrorCallback type, but I don't expect there to be many (any?) custom implementations.
asvoboda
approved these changes
Aug 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are non-default because they require a metrics registry, but the
default handlers are now implemented by passing a nil registry to the
metric version.
Note that this contains an API break in the AsyncErrorCallback type, but
I don't expect there to be many (any?) custom implementations.
Closes #51.