Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Excavator: Upgrades Baseline to the latest version #1096

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ public final class AssertjCollectionHasSizeExactly<T> {

@BeforeTemplate
void bad1(Collection<T> things, int size) {
assertThat(things.size() == size).isTrue();
assertThat(things.size()).isEqualTo(size);
}

@BeforeTemplate
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ public final class AssertjCollectionHasSizeExactlyWithDescription<T> {

@BeforeTemplate
void bad1(Collection<T> things, int size, String description, @Repeated Object descriptionArgs) {
assertThat(things.size() == size).describedAs(description, descriptionArgs).isTrue();
assertThat(things.size()).describedAs(description, descriptionArgs).isEqualTo(size);
}

@BeforeTemplate
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ public final class AssertjCollectionHasSizeGreaterThan<T> {

@BeforeTemplate
void before1(Collection<T> things, int size) {
assertThat(things.size() > size).isTrue();
assertThat(things.size()).isGreaterThan(size);
}

@BeforeTemplate
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ public final class AssertjCollectionHasSizeGreaterThanWithDescription<T> {

@BeforeTemplate
void before1(Collection<T> things, int size, String description, @Repeated Object descriptionArgs) {
assertThat(things.size() > size).describedAs(description, descriptionArgs).isTrue();
assertThat(things.size()).describedAs(description, descriptionArgs).isGreaterThan(size);
}

@BeforeTemplate
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ public final class AssertjCollectionIsEmpty<T> {

@BeforeTemplate
void bad1(Collection<T> things) {
assertThat(things.size() == 0).isTrue();
assertThat(things.size()).isEqualTo(0);
}

@BeforeTemplate
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ public final class AssertjCollectionIsEmptyWithDescription<T> {

@BeforeTemplate
void bad1(Collection<T> things, String description, @Repeated Object descriptionArgs) {
assertThat(things.size() == 0).describedAs(description, descriptionArgs).isTrue();
assertThat(things.size()).describedAs(description, descriptionArgs).isEqualTo(0);
}

@BeforeTemplate
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,12 +31,12 @@ public final class AssertjCollectionIsNotEmpty<T> {

@BeforeTemplate
void bad1(Collection<T> things) {
assertThat(things.size() != 0).isTrue();
assertThat(things.size()).isNotEqualTo(0);
}

@BeforeTemplate
void bad2(Collection<T> things) {
assertThat(things.size() == 0).isFalse();
assertThat(things.size()).isNotEqualTo(0);
}

@BeforeTemplate
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,12 +32,12 @@ public final class AssertjCollectionIsNotEmptyWithDescription<T> {

@BeforeTemplate
void bad1(Collection<T> things, String description, @Repeated Object descriptionArgs) {
assertThat(things.size() != 0).describedAs(description, descriptionArgs).isTrue();
assertThat(things.size()).describedAs(description, descriptionArgs).isNotEqualTo(0);
}

@BeforeTemplate
void bad2(Collection<T> things, String description, @Repeated Object descriptionArgs) {
assertThat(things.size() == 0).describedAs(description, descriptionArgs).isFalse();
assertThat(things.size()).describedAs(description, descriptionArgs).isNotEqualTo(0);
}

@BeforeTemplate
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ public final class AssertjMapHasSizeExactly<K, V> {

@BeforeTemplate
void before1(Map<K, V> things, int size) {
assertThat(things.size() == size).isTrue();
assertThat(things.size()).isEqualTo(size);
}

@BeforeTemplate
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ public final class AssertjMapHasSizeExactlyWithDescription<K, V> {

@BeforeTemplate
void before1(Map<K, V> things, int size, String description, @Repeated Object descriptionArgs) {
assertThat(things.size() == size).describedAs(description, descriptionArgs).isTrue();
assertThat(things.size()).describedAs(description, descriptionArgs).isEqualTo(size);
}

@BeforeTemplate
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ public final class AssertjMapIsEmpty<K, V> {

@BeforeTemplate
void before1(Map<K, V> things) {
assertThat(things.size() == 0).isTrue();
assertThat(things.size()).isEqualTo(0);
}

@BeforeTemplate
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ public final class AssertjMapIsEmptyWithDescription<K, V> {

@BeforeTemplate
void before1(Map<K, V> things, String description, @Repeated Object descriptionArgs) {
assertThat(things.size() == 0).describedAs(description, descriptionArgs).isTrue();
assertThat(things.size()).describedAs(description, descriptionArgs).isEqualTo(0);
}

@BeforeTemplate
Expand Down
2 changes: 1 addition & 1 deletion build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ buildscript {
classpath 'com.jfrog.bintray.gradle:gradle-bintray-plugin:1.8.4'
classpath 'com.netflix.nebula:nebula-publishing-plugin:14.1.1'
classpath 'com.netflix.nebula:gradle-info-plugin:5.2.0'
classpath 'com.palantir.baseline:gradle-baseline-java:2.40.0'
classpath 'com.palantir.baseline:gradle-baseline-java:2.41.0'
}
}

Expand Down