Implement error-prone ClassInitializationDeadlock check #1598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate changelog in
|
fawind
reviewed
Jan 5, 2021
...or-prone/src/test/java/com/palantir/baseline/errorprone/ClassInitializationDeadlockTest.java
Outdated
Show resolved
Hide resolved
fawind
reviewed
Jan 5, 2021
...or-prone/src/test/java/com/palantir/baseline/errorprone/ClassInitializationDeadlockTest.java
Outdated
Show resolved
Hide resolved
fawind
approved these changes
Jan 5, 2021
|
For future reference, an example of where we ran into the issue: palantir/conjure-java#1211 |
|
Released 3.62.0 |
This was referenced Jan 6, 2021
This was referenced Jun 22, 2021
This was referenced Sep 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
Deadlocks which require API/ABI changes to resolve. It's a far better use of resources to alert on these using static analysis than to deadlock every N service startups depending on architecture, JVM, and luck.
After this PR
==COMMIT_MSG==
Implement error-prone ClassInitializationDeadlock check
==COMMIT_MSG==
Possible downsides?
Might produce noise in some projects, however in those cases it's tremendously easy to inadvertently shoot ourselves in the foot.