Remove ClassInitializationDeadlock #2806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkoenig10
force-pushed
the
pkoenig/classInitializationDeadlock
branch
from
d4315b0
to
efb1d9b
Compare
fawind
approved these changes
May 30, 2024
|
Released 5.54.0 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in preparation to upgrade ErrorProne. We can't upgrade until we remove this check and upgrade Baseline in this repo because the
ClassInitializationDeadlockcheck conflicts with the identically named check contributed upstream in google/error-prone#2062.Trying to compile with Error Prone 2.27.0 produces:
In a follow up PR I will upgrade Baseline and Error Prone so we once again have a
ClassInitializationDeadlockcheck.