Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ErrorProne PreferAssertj migration to AssertJ from org.junit.Assert #841

Merged
merged 8 commits into from
Sep 17, 2019
Merged

ErrorProne PreferAssertj migration to AssertJ from org.junit.Assert #841

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
bfce514
ErrorProne PreferAssertj migration to AssertJ from org.junit.Assert
carterkozak Sep 17, 2019
c78646d
Add generated changelog entries
carterkozak Sep 17, 2019
74d97e9
Use static fail import
carterkozak Sep 17, 2019
5e37a0d
Support older legacy Assert classes:
carterkozak Sep 17, 2019
e58ce40
note PreferAssertj in README.md
carterkozak Sep 17, 2019
794e49f
remove duplicate message definition
carterkozak Sep 17, 2019
3077b8a
Support Assert.assertThat and MatcherAssert.assertThat
carterkozak Sep 17, 2019
9b76208
Run migration by default
carterkozak Sep 17, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,6 +168,7 @@ Safe Logging can be found at [github.com/palantir/safe-logging](https://github.c
- `SafeLoggingExceptionMessageFormat`: SafeLoggable exceptions do not interpolate parameters.
- `StrictUnusedVariable`: Functions shouldn't have unused parameters.
- `StringBuilderConstantParameters`: StringBuilder with a constant number of parameters should be replaced by simple concatenation.
- `PreferAssertj`: Prefer AssertJ fluent assertions.

## com.palantir.baseline-checkstyle
Checkstyle rules can be suppressed on a per-line or per-block basis. (It is good practice to first consider formatting
Expand Down
1 change: 1 addition & 0 deletions baseline-error-prone/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ dependencies {
testCompile 'org.slf4j:slf4j-api'
testCompile 'org.apache.commons:commons-lang3'
testCompile 'commons-lang:commons-lang'
testCompile 'org.assertj:assertj-core'
testCompile 'org.junit.jupiter:junit-jupiter-api'
testCompile gradleApi()
testRuntimeOnly 'org.junit.jupiter:junit-jupiter-migrationsupport'
Expand Down
Loading