Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Excavator: Upgrades Baseline to the latest version #338

Merged
merged 1 commit into from
Dec 4, 2019

Conversation

svc-excavator-bot
Copy link
Collaborator

@svc-excavator-bot svc-excavator-bot commented Nov 22, 2019

excavator is a bot for automating changes across repositories.

Changes produced by the roomba/latest-baseline-oss check.

Release Notes

2.32.0

Type Description Link
Fix Checkstyle no longer complains about single-line javadoc produced by palantir-java-format. palantir/gradle-baseline#1051
Improvement PreferAssertj disallows assert statements in test code.

Tests should use more specific AssertJ checks, which cannot be disabled by turning off asserts. Arguably the assert keyword should never be used, preferring preconditions. This way production environments cannot reach code paths that are impossible to test.
palantir/gradle-baseline#1052

2.33.0

Type Description Link
Improvement Implement Slf4jThrowable check to ensure throwable args are logged last palantir/gradle-baseline#1054

2.34.0

Type Description Link
Improvement Adds an ErrorProne rule, JooqResultStreamLeak, which ensures that result streams and cursors returned from jOOQ results are closed in a try-with-resources block. palantir/gradle-baseline#1055

2.35.0

Type Description Link
Improvement Refaster rule to remove unnecessary supplier creation palantir/gradle-baseline#1059
Improvement Add Refaster rule to convert Stream.of() -> Stream.empty() palantir/gradle-baseline#1061

2.35.1

Type Description Link
Fix Revert "Refaster rule to remove unnecessary supplier creation (#1059)"
The refaster rule breaks the common pattern:
Suppliers.memoize(supplier::get).
palantir/gradle-baseline#1063

2.35.2

Type Description Link
Fix Allow declaring that conversion to palantir-java-format has been started, which ensures that conflicting checkstyle rules are removed. palantir/gradle-baseline#1064

2.36.0

Type Description Link
Fix Replace refaster StreamEmpty with error prone StreamOfEmpty to allow refactors to retain type arguments. palantir/gradle-baseline#1068
Improvement RedundantMethodReference check to avoid unnecessary method references palantir/gradle-baseline#1069
Improvement PreferAssertj iterable-map fix retains map type parameters palantir/gradle-baseline#1071

2.37.0

Type Description Link
Improvement refaster will automatically fix up assertions between primitives (a == b) to provide better error messages palantir/gradle-baseline#1078
Improvement Error prone AssertjPrimitiveComparison for primitive comparisons

Prefer using AssertJ fluent comparisons over logic in an assertThat
statement for better failure output. assertThat(a == b).isTrue()
failures report 'expected true' where assertThat(a).isEqualTo(b)
provides the expected and actual values.
palantir/gradle-baseline#1079

2.38.0

Type Description Link
Improvement We now run error-prone 2.3.4, to benefit from smarter static analysis, and hopefully pick up the claimed performance Improvements:

> 40% speedup when run against Google's codebase with errors enabled.
palantir/gradle-baseline#1082

2.39.0

Type Description Link
Improvement Baseline now depends on mockito-errorprone to get Mockito error-prone checks. palantir/gradle-baseline#1085

To enable or disable this check, please contact the maintainers of Excavator.

@svc-excavator-bot svc-excavator-bot force-pushed the roomba/latest-baseline-oss branch from 4679909 to 7f7b7df Compare December 4, 2019 07:38
@bulldozer-bot bulldozer-bot bot merged commit 417f00a into develop Dec 4, 2019
@bulldozer-bot bulldozer-bot bot deleted the roomba/latest-baseline-oss branch December 4, 2019 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants