Run publishToMavenLocal
as a dependency of build
#362
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
Similar to the myriad of problems we've had internally, we don't run
publishToMavenLocal
as part of build. It does current run as part oftrial-publish
, but I want to remove this circle job, as the internal version is useless (uses--dry-run
) and is waste of resources/computing power (and I want internal + external to look similar).This means (without trial-publish) the various publishable artifacts may never get built at PR time, so a change could break building some artifact, the PR build does not even build it, build is green, PR merges, publish breaks when it tries to build the artifact.
After this PR
==COMMIT_MSG==
Run
publishToMavenLocal
as a dependency ofbuild
to ensure publishable artifacts are built as part of PR builds and do not spuriously merge and then break publishing on develop.==COMMIT_MSG==
Possible downsides?