Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run publishToMavenLocal as a dependency of build #362

Merged
merged 4 commits into from
Feb 9, 2024

Conversation

CRogers
Copy link
Contributor

@CRogers CRogers commented Feb 9, 2024

Before this PR

Similar to the myriad of problems we've had internally, we don't run publishToMavenLocal as part of build. It does current run as part of trial-publish, but I want to remove this circle job, as the internal version is useless (uses --dry-run) and is waste of resources/computing power (and I want internal + external to look similar).

This means (without trial-publish) the various publishable artifacts may never get built at PR time, so a change could break building some artifact, the PR build does not even build it, build is green, PR merges, publish breaks when it tries to build the artifact.

After this PR

==COMMIT_MSG==
Run publishToMavenLocal as a dependency of build to ensure publishable artifacts are built as part of PR builds and do not spuriously merge and then break publishing on develop.
==COMMIT_MSG==

Possible downsides?

@CRogers CRogers requested a review from felixdesouza February 9, 2024 13:44
@changelog-app
Copy link

changelog-app bot commented Feb 9, 2024

Generate changelog in changelog/@unreleased

What do the change types mean?
  • feature: A new feature of the service.
  • improvement: An incremental improvement in the functionality or operation of the service.
  • fix: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way.
  • break: Has the potential to break consumers of this service's API, inclusive of both Palantir services
    and external consumers of the service's API (e.g. customer-written software or integrations).
  • deprecation: Advertises the intention to remove service functionality without any change to the
    operation of the service itself.
  • manualTask: Requires the possibility of manual intervention (running a script, eyeballing configuration,
    performing database surgery, ...) at the time of upgrade for it to succeed.
  • migration: A fully automatic upgrade migration task with no engineer input required.

Note: only one type should be chosen.

How are new versions calculated?
  • ❗The break and manual task changelog types will result in a major release!
  • 🐛 The fix changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease.
  • ✨ All others will result in a minor version release.

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

Run publishToMavenLocal as a dependency of build to ensure publishable artifacts are built as part of PR builds and do not spuriously merge and then break publishing on develop.

Check the box to generate changelog(s)

  • Generate changelog entry

@bulldozer-bot bulldozer-bot bot merged commit f125d70 into develop Feb 9, 2024
5 checks passed
@bulldozer-bot bulldozer-bot bot deleted the callumr/pTML-on-build branch February 9, 2024 14:46
@svc-autorelease
Copy link
Collaborator

Released 1.13.0

@pkoenig10 pkoenig10 mentioned this pull request Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants