Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get sonatype URL from env vars #442

Merged
merged 3 commits into from
Sep 2, 2024

Conversation

FinlayRJW
Copy link
Contributor

Before this PR

Currently we use the old sonatype instance which can result in very slow syncs. We should switch over to the new s01 instance as described in Nexus Publish Plugin.

After this PR

Now the sonatype URL can be set using environment variables, this will allow us to switch over to the s01 sonatype instance with minimal downtime.

Possible downsides?

We now have to maintain an extra two environment variables

@FinlayRJW FinlayRJW requested a review from CRogers September 2, 2024 12:38
@changelog-app
Copy link

changelog-app bot commented Sep 2, 2024

Generate changelog in changelog/@unreleased

What do the change types mean?
  • feature: A new feature of the service.
  • improvement: An incremental improvement in the functionality or operation of the service.
  • fix: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way.
  • break: Has the potential to break consumers of this service's API, inclusive of both Palantir services
    and external consumers of the service's API (e.g. customer-written software or integrations).
  • deprecation: Advertises the intention to remove service functionality without any change to the
    operation of the service itself.
  • manualTask: Requires the possibility of manual intervention (running a script, eyeballing configuration,
    performing database surgery, ...) at the time of upgrade for it to succeed.
  • migration: A fully automatic upgrade migration task with no engineer input required.

Note: only one type should be chosen.

How are new versions calculated?
  • ❗The break and manual task changelog types will result in a major release!
  • 🐛 The fix changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease.
  • ✨ All others will result in a minor version release.

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

Get sonatype URL from env vars

Check the box to generate changelog(s)

  • Generate changelog entry

@bulldozer-bot bulldozer-bot bot merged commit 03687e3 into develop Sep 2, 2024
5 checks passed
@bulldozer-bot bulldozer-bot bot deleted the finlayw/use_env_var_for_sonatype_url branch September 2, 2024 13:08
@autorelease3
Copy link

autorelease3 bot commented Sep 2, 2024

Released 1.17.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants