Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CME in JdkDownloaders #39

Merged
merged 2 commits into from
May 17, 2022
Merged

Fix CME in JdkDownloaders #39

merged 2 commits into from
May 17, 2022

Conversation

CRogers
Copy link
Contributor

@CRogers CRogers commented May 17, 2022

Before this PR

Once again I failed to clock that JdkDownloaders is accessed by multiple threads. There is a CME that happens here:

Caused by: java.util.ConcurrentModificationException: (No message provided)
        at com.palantir.gradle.jdks.JdkDownloaders.jdkDownloaderFor(JdkDownloaders.java:34)
        at com.palantir.gradle.jdks.JdkManager.jdk(JdkManager.java:62)
        at com.palantir.gradle.jdks.JdksPlugin.lambda$javaInstallationForLanguageVersion$5(JdksPlugin.java:86)

After this PR

==COMMIT_MSG==
Fix ConcurrentModificationException from JdkDownloaders.
==COMMIT_MSG==

Possible downsides?

@CRogers CRogers requested a review from carterkozak May 17, 2022 12:41
@changelog-app
Copy link

changelog-app bot commented May 17, 2022 •
edited by CRogers
Loading

Generate changelog in changelog/@unreleased

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

Fix ConcurrentModificationException from JdkDownloaders.

Check the box to generate changelog(s)

  • Generate changelog entry

@CRogers CRogers merged commit 35b8041 into develop May 17, 2022
@svc-autorelease
Copy link
Collaborator

Released 0.10.0

@CRogers CRogers deleted the callumr/fix-more-cmes branch May 17, 2022 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carterkozak carterkozak Awaiting requested review from carterkozak

Assignees
No one assigned
Labels
autorelease
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CRogers @svc-autorelease @svc-changelog