Add has_successful_status predicate #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… has-status-passed
bluekeyes
requested changes
Dec 5, 2019
| @@ -114,12 +115,12 @@ func (h *Status) processOthers(ctx context.Context, event github.StatusEvent) er | |||
|
|
|||
| // In practice, there should only be one or two open PRs for a given commit. In exceptional cases, if there are | |||
| // more than 100 open PRs, only process the most recent 100. | |||
| prs, _, err := client.PullRequests.List( | |||
| prs, _, err := client.PullRequests.ListPullRequestsWithCommit( | |||
There was a problem hiding this comment.
Nice, I didn't know this endpoint existed in the v3 API. Per the docs, it looks like it returns both closed and open PRs:
Lists all pull requests containing the provided commit SHA, which can be from any point in the commit history. The results will include open and closed pull requests.
I think the 100 PR limit is probably still safe in practice (although the comment is inaccurate now), but we do need to filter the results to only evaluate open PRs in the loop on L132.
server/handler/status.go
Outdated
| @@ -137,6 +138,9 @@ func (h *Status) processOthers(ctx context.Context, event github.StatusEvent) er | |||
| }) | |||
| if err != nil { | |||
| evaluationFailures++ | |||
| logger.Error().Err(err).Msgf("failed to evaluate pull request '%d' for SHA '%s'", pr.GetNumber(), | |||
There was a problem hiding this comment.
style: Failed to .... In this codebase, log message usually start with a captial letter, errors with a lowercase letter.
bluekeyes
approved these changes
Dec 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continues the work started by @pilbot in #139. I don't have permission to push to that branch, thus the new one.
Fixes #102.