New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix broken docs URL, missing v prefix #190

Merged

bluekeyes merged 1 commit into develop from jc/fix-docs-URL

Jun 5, 2020

Member

jmcampanini commented Jun 5, 2020

Given that:

the latest tag has a v prefix
godel's version.GetVersion strips the leading v prefix

We end up in a situation where the docs URL being constructed doesn't exist (since the URL is missing the v prefix).

This PR adds the prefix explicitly.


          add the v prefix back to docs URL

edf2029

jmcampanini requested a review from bluekeyes

June 5, 2020 21:12

bluekeyes approved these changes

View reviewed changes

bluekeyes merged commit 6c116ee into develop

bluekeyes deleted the jc/fix-docs-URL branch

June 5, 2020 21:41

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet