Load pull request draft status from GraphQL API #742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Back in 2019, we disabled this field because it was part of a GraphQL preview. As a result, IsDraft was always false for PRs that we loaded via the GraphQL query. For the most part, this doesn't matter, but can cause problems with reviewer requests triggered via webhooks (like status events) that do not provide complete pull request details. This field has been out of preview for a long time now and is available in all supported versions of GitHub, so it should be safe to load.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Back in 2019, we disabled this field because it was part of a GraphQL preview. As a result, IsDraft was always false for PRs that we loaded via the GraphQL query. For the most part, this doesn't matter, but can cause problems with reviewer requests triggered via webhooks (like status events) that do not provide complete pull request details.
This field has been out of preview for a long time now and is available in all supported versions of GitHub, so it should be safe to load.
Fixes #741.