Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't look at workflow run results in other repositories #861

Merged

Conversation

iainlane
Copy link
Contributor

@iainlane iainlane commented Oct 9, 2024

This is a copy of 536d202. The same issue exists with the workflow_run event as with check_run. People can fork a repository and then propose pull requests from the original repository into their fork. This may result in webhooks being dispatched, but we want to ignore them.

I did have a quick think about whether there was somewhere common to put this, since it's in two places now, but I couldn't see anywhere decent. I'd still be happy to move this, though, if there is a better place.

This is a copy of 536d202. The same
issue exists with the `workflow_run` event as with `check_run`. People
can fork a repository and then propose pull requests from the original
repository into their fork. This may result in webhooks being
dispatched, but we want to ignore them.
Copy link
Member

@bluekeyes bluekeyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I think it's fine to duplicate this logic in the handlers

@bluekeyes bluekeyes merged commit 758ecc9 into palantir:develop Oct 9, 2024
8 checks passed
@iainlane iainlane deleted the iainlane/workflow-run-skip-other-repos branch October 9, 2024 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants