Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make flake8 plugin use stdin #830

Merged
merged 1 commit into from
Jul 2, 2020
Merged

Make flake8 plugin use stdin #830

merged 1 commit into from
Jul 2, 2020

Conversation

qbedard
Copy link
Contributor

@qbedard qbedard commented Jul 2, 2020

This resolves #743. It may also resolve #825, but I have not tested to be sure.

@palantirtech
Copy link
Member

Thanks for your interest in palantir/python-language-server, @timbedard! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request.

@ccordoba12 ccordoba12 added this to the 0.34.1 milestone Jul 2, 2020
ccordoba12
ccordoba12 approved these changes Jul 2, 2020
View reviewed changes
Copy link
Contributor

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your help @timbedard! Looks good to me.

@ccordoba12 ccordoba12 merged commit 78dee3d into palantir:develop Jul 2, 2020
@qbedard
Copy link
Contributor Author

qbedard commented Jul 2, 2020

Happy to do what I can. 😁

@qbedard qbedard deleted the flake8-use-stdin branch July 2, 2020 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccordoba12 ccordoba12 ccordoba12 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.34.1
3 participants
@qbedard @palantirtech @ccordoba12