Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
LoggableExceptionAssert#hasArgs
only checks whether the given args are contained in the actual args. The name of this method in misleading, as many users probably assume that the method checks that the args are exactly equal. This leads to weaker tests than users may have intended.This is particularly confusing because
ServiceExceptionAssert#hasArgs
has the same name but does check that the args are exactly equal.After this PR
LoggableExceptionAssert#hasArgs
is marked as deprecated in favor of a new method, ``LoggableExceptionAssert#containsArgs`. This should more clearly signal the behavior of this method to users.This also more closely matches the naming convention of iterables asserts in AssertJ.