Add @Nullable
annotations to exception causes
#869
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
Baseline's nullaway plugin blocks calling these constructors with a
null
cause:But null causes are explicitly allowed in the JDK for this parameter:
https://github.com/openjdk/jdk/blob/46c4da7fddb8103934f2a90b4456a5ce6ed3467c/src/java.base/share/classes/java/lang/Exception.java#L79-L81
So we need to tell nullaway that this pattern is nullable, and the standard way to do that is with the
javax.annotation.Nullable
annotation.After this PR
==COMMIT_MSG==
Add
@Nullable
annotations to exception causes==COMMIT_MSG==