Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Async JVM Unified Logging on JDK 17+ #1374

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from
Draft

Conversation

schlosna
Copy link
Contributor

@schlosna schlosna commented Aug 5, 2022

Before this PR

#1373

After this PR

==COMMIT_MSG==
Use Async JVM Unified Logging on JDK 17+

Avoid fflush from Unified JVM Logging (e.g. GC logs), see:

https://aws.amazon.com/blogs/developer/asynchronous-logging-corretto-17/
https://bugs.openjdk.org/browse/JDK-8291898
https://bugs.openjdk.org/browse/JDK-8229517
openjdk/jdk@41185d3
==COMMIT_MSG==

Possible downsides?

@changelog-app
Copy link

changelog-app bot commented Aug 5, 2022

Generate changelog in changelog/@unreleased

Type
See change types. Select one:

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

Use Async JVM Unified Logging on JDK 17+

Avoid fflush from Unified JVM Logging (e.g. GC logs), see:

https://aws.amazon.com/blogs/developer/asynchronous-logging-corretto-17/
https://bugs.openjdk.org/browse/JDK-8291898
https://bugs.openjdk.org/browse/JDK-8229517
openjdk/jdk@41185d3

Check the box to generate changelog(s)

  • Generate changelog entry

Copy link
Contributor

@carterkozak carterkozak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let’s plan to roll this out toward the second half of next week to avoid risk with jdk11 workarounds.

@schlosna
Copy link
Contributor Author

schlosna commented Aug 5, 2022

Definitely planning to hold on this until calmer seas

@schlosna
Copy link
Contributor Author

schlosna commented Sep 5, 2022

Related :
JDK-8292989: Avoid dynamic memory in AsyncLogWriter
JDK-8299415: Saturate the async log buffer more often

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants