fixup! Upgrade to TypeScript 3.8

palantir · Feb 28, 2020 · e0d4509 · e0d4509
1 parent 1b4cae0
commit e0d4509
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 3 deletions.
diff --git a/src/language/utils.ts b/src/language/utils.ts
@@ -582,3 +582,9 @@ export function isWhiteSpace(ch: number): boolean {
     // tslint:disable-next-line
     return (ts.isWhiteSpaceLike || (ts as any).isWhiteSpace)(ch);
 }
+
+/** Wrapper for compatability with typescript@<3.8.2 */
+export function isPrivateIdentifier(node: ts.Node): node is ts.PrivateIdentifier {
+    // tslint:disable-next-line
+    return ts.isPrivateIdentifier ? ts.isPrivateIdentifier(node) : false;
+}
diff --git a/src/rules/importBlacklistRule.ts b/src/rules/importBlacklistRule.ts
@@ -20,6 +20,7 @@ import {
     ImportKind,
     isExportDeclaration,
     isImportDeclaration,
+    isNamedExports,
     isNamedImports,
 } from "tsutils";
 import * as ts from "typescript";
@@ -237,7 +238,7 @@ function walk(ctx: Lint.WalkContext<Options>) {
                               toExportName,
                           )
                         : []),
-                    ...(exportClause && ts.isNamedExports(exportClause)
+                    ...(exportClause !== undefined && isNamedExports(exportClause)
                         ? exportClause.elements.map(toExportName)
                         : []),
                 ];

diff --git a/src/rules/noUnnecessaryQualifierRule.ts b/src/rules/noUnnecessaryQualifierRule.ts
@@ -64,7 +64,7 @@ function walk(ctx: Lint.WalkContext, checker: ts.TypeChecker): void {
 
             case ts.SyntaxKind.PropertyAccessExpression:
                 const { expression, name } = node as ts.PropertyAccessExpression;
-                if (utils.isEntityNameExpression(expression) && !ts.isPrivateIdentifier(name)) {
+                if (utils.isEntityNameExpression(expression) && !Lint.isPrivateIdentifier(name)) {
                     visitNamespaceAccess(node, expression, name);
                     break;
                 }

diff --git a/src/rules/whitespaceRule.ts b/src/rules/whitespaceRule.ts
@@ -175,7 +175,7 @@ function walk(ctx: Lint.WalkContext<Options>) {
                 if (
                     options.module &&
                     exportClause !== undefined &&
-                    ts.isNamedExports(exportClause)
+                    utils.isNamedExports(exportClause)
                 ) {
                     exportClause.elements.forEach((element, idx, arr) => {
                         if (idx === arr.length - 1) {