Skip to content
This repository has been archived by the owner on Mar 25, 2021. It is now read-only.

Adding class expression checks to max-classes-per-file rule #1666

Merged
merged 1 commit into from
Nov 2, 2016
Merged

Adding class expression checks to max-classes-per-file rule #1666

merged 1 commit into from
Nov 2, 2016

Conversation

ChrisMBarr
Copy link
Contributor

@ChrisMBarr ChrisMBarr commented Nov 1, 2016 •
edited
Loading

Just an update to #1656 that adds support & tests for checking class expressions to the new max-classes-per-file rule

( I wasn't quick enough in my last PR!)

@ChrisMBarr ChrisMBarr changed the title Adding class expression checks Adding class expression checks to max-classes-per-file rule Nov 1, 2016
adidahiya
adidahiya approved these changes Nov 2, 2016
View reviewed changes
Copy link
Contributor

@adidahiya adidahiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks.

@adidahiya adidahiya merged commit 276c6e4 into palantir:master Nov 2, 2016
@ChrisMBarr ChrisMBarr deleted the max-classes-per-file-class-expr-support branch November 2, 2016 17:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@adidahiya adidahiya adidahiya approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ChrisMBarr @adidahiya