This repository has been archived by the owner on Mar 25, 2021. It is now read-only.
Fix error saying severity is missing #2516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
Overview of change:
TSLint was looking up the rule severity for all failures even if the rule was already assigned a severity in a previous file linting. This is a problem when there are multiple tslint.json files in different directories (TSLint uses Node resolution to determine which one applies) and if a rule is enabled and becomes disabled later. If failure for rule X occurs, then X is disabled, it will attempt to look up the severity of X again, and it won't be found
fixes #2476
Is there anything you'd like reviewers to focus on?
CHANGELOG.md entry:
[bugfix] Fixes "Severity for rule not found" error