This repository has been archived by the owner on Mar 25, 2021. It is now read-only.
Inherit defaultSeverity and apply it to preceding base configs #3530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
adidahiya
approved these changes
Jan 10, 2018
| @@ -0,0 +1,8 @@ | |||
| { | |||
There was a problem hiding this comment.
nit: file name has a typo. "precedence". I'll fix this in a follow-up.
…ends-default-severity-precedence.json
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #3449. Only my commits after the merge are relevant for this PR.
This adds the missing piece to inherit the
defaultSeverityfrom the last base config that specifies it. This inherited default is then applied to all base configs.It turned out to be a bit complicated to do this while still maintaining a backwards compatible API.