This repository has been archived by the owner on Mar 25, 2021. It is now read-only.
TypeScript 2.8 & 2.9 adaptations (dependencies & tests) #3792
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
Overview of changes:
As a dependant module with npm 2.x
Adding typescript 2.9.0-dev to
peerDependencies
, as modules depending on"typescript": "next"
and tslint are failing to install with npm version 2.x (as npm versions prior to 3 were failing unmet peerDependencies):package.json:
Updates for TypeScript 2.8+
Many places previously returned empty string as text when JSDoc declaration had no comment, but now it returns
undefined
and it was failing the tests fortypescript@next
.Is there anything you'd like reviewers to focus on?
-- none --
CHANGELOG.md entry:
[bugfix] Using tslint with typescript 2.9.0 would cause errors under npm 2.x