tsfmt task

[weswigham]

For your consideration. I find it's output somewhat lacking, though.

[myitcv]

Picking up on this thread

its output leaves a lot to be desired:

 D:\rep\tslint ⮀ ⭠ modularize ⮀ grunt tsfmt
Running "tsfmt:src" (tsfmt) task
> src/configuration.ts is not formatted
> src/enableDisableRules.ts is not formatted

The output is just fine, it doesn't need to be any more verbose. tsfmt shouldn't tell you how to fix the problem; you should simply run tsfmt on the file itself and it will fix it for you. Why would you want to fix it by hand?

To fix the entire source tree (one off):

tsfmt -r *(app|src)/**/*.{ts,tsx}

For what it's worth, I have tsfmt running whenever I save a file in my editor. That way things never get out of step.

[jkillian]

@weswigham Can you rebase this?

I haven't tried tsfmt or the typescript compiler formatting tools which it's based on. From the description though, the formatting they do seems pretty unobtrusive. I wouldn't want to merge in a tool that does overly zealous reformatting (for example, if I have a multiline conditional statement, I wouldn't want a tool that combines it all into one line).

I'm assuming based on both of your comments that tsfmt does an appropriate level of adjustments?

[myitcv]

@jkillian - because there is no standard format for TypeScript code (which I consider to be a weakness) you may find you want to set tsfmt options.

Does this PR actually enforce, as part of the build, that all code is formatted?

Because the build is green, yet when checked out locally I see:

tsfmt --verify *(src|test)/**/*.{ts,tsx}

shows that 217 files are not formatted.

Incidentally, formatting those files creates the following diff (ignoring whitespace changes):

https://gist.github.com/myitcv/0f83f6ce02d184f26f69

[jkillian]

Interesting catch with running tsfmt on the whole project - we would not want it to run on .test.ts files. These are intentionally formatted poorly sometimes, and auto-formatting them could mess that up. I like the idea of using it on the source code though, I want to take a look at a diff that includes whitespace changes and only the real source code and see what it looks like.

[weswigham]

This PR just contains a tsfmt verification task. It doesn't add it to the
build step.

On Sat, Oct 17, 2015, 10:06 AM Jason Killian notifications@github.com
wrote:

Interesting catch with running tsfmt on the whole project - we would not
want it to run on .test.ts files. These are intentionally formatted
poorly sometimes, and auto-formatting them could mess that up. I like the
idea of using it on the source code though, I want to take a look at a diff
that includes whitespace changes and only the real source code and see what
it looks like.

—
Reply to this email directly or view it on GitHub
#732 (comment).

[weswigham]

I'd recommend someone else pick up this patch and update it if you're still interested in the build step (I still think tsfmt's pass/fail output is lacking, though), I've been focusing on other bits lately.

[jkillian]

Closing this in favor of #841, thanks for this idea @weswigham!