This repository has been archived by the owner on Mar 25, 2021. It is now read-only.
Fix no-unused-variable "react" option to support self-closing JSX elements #776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
self-closing JSX elements. Also reorder some methods in NoUnusedVariableWalker.
| public visitJsxSelfClosingElement(node: ts.JsxSelfClosingElement) { | ||
| this.hasSeenJsxElement = true; | ||
| super.visitJsxSelfClosingElement(node); | ||
| } |
There was a problem hiding this comment.
this method was added. the others were reordered to be alphabetized.
There was a problem hiding this comment.
Thanks - this was indeed the bug. You beat me to a PR 👍
| @@ -136,6 +136,10 @@ describe("<no-unused-variable>", () => { | |||
|
|
|||
| describeSuite("react"); | |||
| describeSuite("react/addons"); | |||
|
|
|||
| it("should not fail if JSX self-closing element is used", () => { | |||
There was a problem hiding this comment.
Can we do this like the other tests for consistency?
jkillian
added a commit
that referenced
this pull request
Nov 13, 2015
Fix no-unused-variable "react" option to support self-closing JSX elements
|
[Changes can be made in a follow-up commit, want to merge this to prepare for a release] |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also reorder some methods in NoUnusedVariableWalker.